Support Map<String, String> in FormHttpMessageWriter and FormHttpMessageReader#36676
Open
tianhaocui wants to merge 1 commit intospring-projects:mainfrom
Open
Support Map<String, String> in FormHttpMessageWriter and FormHttpMessageReader#36676tianhaocui wants to merge 1 commit intospring-projects:mainfrom
tianhaocui wants to merge 1 commit intospring-projects:mainfrom
Conversation
…ageReader Widen FormHttpMessageWriter and FormHttpMessageReader to support Map<String, String> in addition to MultiValueMap<String, String>, aligning the reactive codecs with the imperative FormHttpMessageConverter which was updated in spring-projects#36408. FormHttpMessageWriter: - Widen generic type from MultiValueMap to Map - canWrite() accepts both Map and MultiValueMap with String values - write() dispatches between MultiValueMap and plain Map serialization - Add serializeForm(Map) overload for plain Map entries FormHttpMessageReader: - Widen generic type from MultiValueMap to Map - canRead() accepts both Map and MultiValueMap with String values - readMono() returns asSingleValueMap() for plain Map target type MultipartHttpMessageWriter: - Widen formWriter field type to HttpMessageWriter<? super MultiValueMap> Closes spring-projects#36536 Signed-off-by: cuitianhao <54015884+tianhaocui@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: web
sbrannen
requested review from
bclozel and
sdeleuze
and removed request for
sdeleuze
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36536
Widens
FormHttpMessageWriterandFormHttpMessageReaderto supportMap<String, String>in addition toMultiValueMap<String, String>, aligning the reactive codecs with the imperativeFormHttpMessageConverterupdated in #36408.FormHttpMessageWriter:
MultiValueMaptoMapcanWrite()accepts bothMapandMultiValueMapwith String valueswrite()dispatches betweenMultiValueMapand plainMapserializationserializeForm(Map)overload for plain Map entriesFormHttpMessageReader:
MultiValueMaptoMapcanRead()accepts bothMapandMultiValueMapwith String valuesreadMono()returnsasSingleValueMap()for plainMaptarget typeMultipartHttpMessageWriter:
formWriterfield type toHttpMessageWriter<? super MultiValueMap<String, String>>